search

HindsightTwentyTwenty / frontend

The Official Front End of Hindsite Inc.
0 stars 1 forks source link

search functionality #328

Open wandaczerwinski opened 7 years ago

wandaczerwinski commented 7 years ago

Need to either fix functionality of page url bars, or disable them. If I don't enter a search term but select a category, should probably show me all pages that I've categorized with that.

trk17 commented 7 years ago

Not entirely following what the issue is here. Isn't this just what the category component is for?

I guess we could let people search with nothing but feels a bit odd.

wandaczerwinski commented 7 years ago

It just felt weird where sometimes if I do enter a search term that is maybe unrelated to my pages content and then also choose a category where I know I have pages, nothing shows up.

zatannenbaum commented 7 years ago

I think that the functionality as you describe it is reasonable. If I search for "dogs" and then filter by a category called "cats" then nothing should show up because there is nothing that contains "dogs" that is categorized as "cats". Maybe the UI should be more explicit in saying no results were found?