Hochschule-Fulda-AI / media-majesty

A digital media marketplace catered to Universities
MIT License
1 stars 0 forks source link

Feature Request - Implement download & price filtering, upload file validation #15

Closed BoudabousAchraf closed 8 months ago

BoudabousAchraf commented 8 months ago
7ze commented 8 months ago

I think we need to update the implementation of seeding for items (At the moment the items are seeded without an actual media file, and it can by pass the file validation), and make sure that media_file field for items model is mandatory.

7ze commented 8 months ago

another small issue I saw was when we filter items by price, the previously selected categories get reset

7ze commented 8 months ago

I noticed another issue, can you please confirm it @BoudabousAchraf. Downloading a file downloads it twice after this commit.

7ze commented 8 months ago

I noticed another issue, can you please confirm it @BoudabousAchraf. Downloading a file downloads it twice after this commit.

Turns out, the download issue was because it was downloading the file to the server (in this case localhost i.e. our machines) instead of directly sending it to the client as attachment, hence causing it to download twice. This was a major hindsight from our side @BoudabousAchraf.