Open creative-brain opened 3 years ago
Thanks for the contribution, looks like some good changes. I'll have to review the code a bit.
The license file in the root folder seems a bit strange. What I have in mind would looke like this:
You based the branch on the planet_collisions
branch, which didn't yet see the bugfixes that master
got recently, so it tends to crash. Does it crash all the time for you too? Not sure what the best approach is here:
master
and leave the collisions branch until performance issues are fixed?master
already? I don't want user experience to suffer.beta
branch which merges both branches? That sound better to me.Some remarks:
This became a small brain dump, so obviously not everything is directly related to your commit.
Alright, I tried to tidily integrate your changes and tweaked some settings. You can check it out on the atmosphere_with_clouds
branch.
I think we could actually create a dev
or beta
branch with these changes and delete planet_collisions
and atmosphere_with_clouds
.
Edit: Moved all changes to dev
branch, so we can use that for feature development.
I can't see nothing about atmosphere_with_clouds
, but I already made a simple clouds.
Should I make a Pull request with this?
Oh, it's the dev
branch now, as I mentioned earlier (see also my edit above).
This looks good already, albeit a bit rough around the edges. You can of course make a pull request if you want, it may take some time until I can take care of these though.
Hello, I saw this plugin integrated my atmosphere plugin, and I actually added volumetric clouds recently, alongside several new versions of the shaders that include light scattering similar to Sebastian Lague's atmosphere video.
However the planet plugin didn't integrate mine by just shipping it under addons/, instead it looks like only certain things were picked and moved in sub-folders so it's not possible to just get the new features by updating my plugin replacing the folder.
Hi, I just pushed a new branch with improved atmosphere and water. I am now working on implementation of optional clouds. In the meantime you can check the changes I made and do some corrections if you want.