HolographicWings / LethalSDK-Unity-Project

Unity Project using Lethal Company SDK
MIT License
43 stars 6 forks source link

Few Questions #49

Closed L-Vi closed 10 months ago

L-Vi commented 10 months ago

Hey HolographicWings. Great work on this so far. Unity project is well put together and it didn't take me long at all to figure out how most of it fits together.

Few queries though:

1 - I'd like to understand a little more about your asset bundling process. Are you cycling through the whole project, or specific folders? I just want to make sure I don't accidentally bundle 3rd party tools / unused assets.

2 - Any idea what's causing this error while bundling?
Two properties with the same reference name (_DoubleSidedEnable) using different types UnityEditor.BuildPipeline:BuildAssetBundles (string,UnityEditor.BuildAssetBundleOptions,UnityEditor.BuildTarget) LethalSDK.Editor.Lethal_AssetBundleBuilderWindow:BuildAssetBundles ()

3 - What exactly are Outdoor Nodes? This is the one item I haven't been able to identify.

4 - I have the itemshipinstancer in it's template project default position. However in game, it is spawning somewhere else and I have no idea where. I hear it somewhere in the distance, possibly very high on the Y axis. Any insights you can provide on this?

And also one suggestion: For future users, please make it more clear that the audio reverb presets are also responsible for changing weather and effects. Took me a good while to figure out that those triggers were what I needed to be using.

HolographicWings commented 10 months ago

Hey HolographicWings. Great work on this so far. Unity project is well put together and it didn't take me long at all to figure out how most of it fits together.

Few queries though:

1 - I'd like to understand a little more about your asset bundling process. Are you cycling through the whole project, or specific folders? I just want to make sure I don't accidentally bundle 3rd party tools / unused assets.

it bundle the folders that are in Assets/Mods each independantly

2 - Any idea what's causing this error while bundling? Two properties with the same reference name (_DoubleSidedEnable) using different types UnityEditor.BuildPipeline:BuildAssetBundles (string,UnityEditor.BuildAssetBundleOptions,UnityEditor.BuildTarget) LethalSDK.Editor.Lethal_AssetBundleBuilderWindow:BuildAssetBundles ()

First time i see it, sometimes restart unity is enough, otherwise check if you don't have a conflict in file names, two files can't have the same names

3 - What exactly are Outdoor Nodes? This is the one item I haven't been able to identify.

OutsideNodes are the spawn spots for everything that are random outside

4 - I have the itemshipinstancer in it's template project default position. However in game, it is spawning somewhere else and I have no idea where. I hear it somewhere in the distance, possibly very high on the Y axis. Any insights you can provide on this?

Tell me more, send me screenshots of the instancer in your project

And also one suggestion: For future users, please make it more clear that the audio reverb presets are also responsible for changing weather and effects. Took me a good while to figure out that those triggers were what I needed to be using.

I may warn it yes, but i don't want to rename the classes, they are ported into the vanilla ones with the same name

L-Vi commented 10 months ago

Thanks for the fast response.

2 - Any idea what's causing this error while bundling? Two properties with the same reference name (_DoubleSidedEnable) using different types UnityEditor.BuildPipeline:BuildAssetBundles (string,UnityEditor.BuildAssetBundleOptions,UnityEditor.BuildTarget) LethalSDK.Editor.Lethal_AssetBundleBuilderWindow:BuildAssetBundles ()

First time i see it, sometimes restart unity is enough, otherwise check if you don't have a conflict in file names, two files can't have the same names

Unfortunately no restarting unity does nothing. _DoubleSidedEnabled is clearly a material property ... probably flora materials. I'll have to try removing assets until I can narrow it down. This is another reason why I wanted to understand what is actually happening in the bundling process.

Tell me more, send me screenshots of the instancer in your project.

Attached. I've also tried adding it to the scene from the prefabs, bringing in a duplicate of the systems gameobject directly from the TemplateMod, and reimporting the project files from your zip. I'm going to be missing something really obvious, I just can't seem to pinpoint it.

I may warn it yes, but i don't want to rename the classes, they are ported into the vanilla ones with the same name

Fair one.

itemship-shot itemship-heirarchy itemship-root-cursed1 itemship-systems itemship-instancer

HolographicWings commented 10 months ago

Thanks for the fast response.

2 - Any idea what's causing this error while bundling? Two properties with the same reference name (_DoubleSidedEnable) using different types UnityEditor.BuildPipeline:BuildAssetBundles (string,UnityEditor.BuildAssetBundleOptions,UnityEditor.BuildTarget) LethalSDK.Editor.Lethal_AssetBundleBuilderWindow:BuildAssetBundles ()

First time i see it, sometimes restart unity is enough, otherwise check if you don't have a conflict in file names, two files can't have the same names

Unfortunately no restarting unity does nothing. _DoubleSidedEnabled is clearly a material property ... probably flora materials. I'll have to try removing assets until I can narrow it down. This is another reason why I wanted to understand what is actually happening in the bundling process.

Tell me more, send me screenshots of the instancer in your project.

Attached. I've also tried adding it to the scene from the prefabs, bringing in a duplicate of the systems gameobject directly from the TemplateMod, and reimporting the project files from your zip. I'm going to be missing something really obvious, I just can't seem to pinpoint it.

I may warn it yes, but i don't want to rename the classes, they are ported into the vanilla ones with the same name

Fair one.

itemship-shot itemship-heirarchy itemship-root-cursed1 itemship-systems itemship-instancer

For material I have no idea I'm sorry

For the ship dropship, can you find where it spawn in game with the Unity Explorer ? And can you tell me if it work properly on wateridge ? It may be a global bug from the recent changes

L-Vi commented 10 months ago

Unity Explorer was a good shout. (in seven years of Unity, how did I not know about this?)

Dropship solved. And good news is that it seems to be my fault and not a bug.

I'll update when I find the answer to the double sided issue.

### Update: Final Item Ship Resolution Note

I had failed to recognize that there was a separate prefab required for entering orbit, and had entered the name of the moon instead. This meant I was spawning the map twice. First time by entering the moon name into the console (entering orbit), and then a second time during the landing phase. I've changed this to Moon1, until such time that I've made an orbit prefab.

itemship-finalanswer

HolographicWings commented 10 months ago

2 - Any idea what's causing this error while bundling?
Two properties with the same reference name (_DoubleSidedEnable) using different types UnityEditor.BuildPipeline:BuildAssetBundles (string,UnityEditor.BuildAssetBundleOptions,UnityEditor.BuildTarget) LethalSDK.Editor.Lethal_AssetBundleBuilderWindow:BuildAssetBundles ()

Check if you don't have two times the same shader or two shaders with the same property name but different types If a "double sided" property is used two times by different types it may be a shader conflict

L-Vi commented 10 months ago

I'm going to close this out as the errors have mysteriously stopped appearing. While I still don't know the cause, I do not believe the issue is related to your project. Many thanks for your help.

HolographicWings commented 10 months ago

I'm going to close this out as the errors have mysteriously stopped appearing. While I still don't know the cause, I do not believe the issue is related to your project. Many thanks for your help.

Unity be like xD