HolographicWings / LethalSDK-Unity-Project

Unity Project using Lethal Company SDK
MIT License
43 stars 4 forks source link

audio problem, I would like to set a time limit on the use of my "airhorn/clownhorn" #77

Closed CidFexon closed 4 months ago

CidFexon commented 4 months ago

Hello, I need help with the sound of my scrap, when I or someone uses it you can activate it endlessly, the problem is that the sound starts again every time we activate it and it quickly becomes deaf to hear.

is there a way to fix it?

I thank you in advance.

HolographicWings commented 4 months ago

To be honest i don't know, i simply port the fields to make the scrap work as an airhorn, i haven't looked at the code of the airhorn at all. Nobody else reported me this issue, so it may be from the encoding of your audio file ? I dunno really

CidFexon commented 4 months ago

I wouldn't be able to say the encoding of my audio file, to be honest I'm just implanting files.

Could you tell me what encoding is used for the airhorn? I looked on the internet and I admit I'm a little lost with all these types of encoding, should it be done in a separate software? or can I do it directly on unity?

HolographicWings commented 4 months ago

I wouldn't be able to say the encoding of my audio file, to be honest I'm just implanting files.

Could you tell me what encoding is used for the airhorn? I looked on the internet and I admit I'm a little lost with all these types of encoding, should it be done in a separate software? or can I do it directly on unity?

I really dunno, all a think is that bad encoring may not be read properly by unity or maybe i tell shit

CidFexon commented 4 months ago

my level of use of unity is very basic, the only thing I think that could solve the problem is at the coding level, by putting a sound activation delay. The sound I used is from a game so I don't think the encoding is a problem (.ogg), the sound works well in the game but restarts with each click and therefore accumulates. Is it possible to modify the sdk modpack code?

HolographicWings commented 4 months ago

my level of use of unity is very basic, the only thing I think that could solve the problem is at the coding level, by putting a sound activation delay. The sound I used is from a game so I don't think the encoding is a problem (.ogg), the sound works well in the game but restarts with each click and therefore accumulates. Is it possible to modify the sdk modpack code?

But modify it for what purpose ? The SDK is just porting the fields to the vanilla classes. Try with any other sound, use a vanilla sound like "GrabFlashlight" and tell me if that still happen

CidFexon commented 4 months ago

I tried to add a classic sound, the grab and even the clownhorn, but it always does the same thing, if you don't spam it works very well, but if I click several times the sound starts again while keeping the old one so This is becoming horrible to hear. I'll send you a video of what it does, then if you don't know where it could come from it's not too serious, I'll try to get by by scratching everywhere, otherwise I'll use another mod to add the sound if it works.

video like : https://youtu.be/Yr1YFndfjwM

HolographicWings commented 4 months ago

As i said, try with GrabFlashlight as sound and tell me if you can spam it please

CidFexon commented 4 months ago

sorry I explained myself badly, I tested with the grabflashlight and it does the same thing, I even tried putting "clownhorn" it does the same thing to me.

video like : https://www.youtube.com/watch?v=ABHGuYx_39w

The only solution I imagined is to create an external dll with an "if" which analyzes each item, finds my items and creates a cooldown via the harmony library

HolographicWings commented 4 months ago

hm can you show me the settings of your scrap ? in the Noisemaker category

CidFexon commented 4 months ago

image

HolographicWings commented 4 months ago

image i will try to add this field in next update i may have forgot it, if it fixes the issue, so thanks you for the report ^^

HolographicWings commented 4 months ago

Added in 1.3.41 of the SDK, tell me if it fixes the issue

CidFexon commented 4 months ago

I just tried to modify the cooldown float but it doesn't seem to want to change, I did as a test: 0 / 1 / 10 / 100 / 5000 but none of these numbers changed :c

HolographicWings commented 4 months ago

Did you used both LE and the SDK 1.3.41 as well ? the mod need to be updated too

CidFexon commented 4 months ago

oh my god, I'm stupid, it was the problem with the lethal expansion version, thank you for helping me with this problem, everything works fine, there is a delay !!

THANK YOU SO MUCH