HolyLab / Imagine

A graphical interface for recording with OCPI microscopes.
1 stars 1 forks source link

Support user-specified analog and digital waveforms #32

Closed Cody-G closed 6 years ago

Cody-G commented 7 years ago

This issue will track progress toward allowing a fully custom set of analog and digital signals to orchestrate a recording with Imagine. Advantages of this approach:

To do:

Cody-G commented 7 years ago

@kdw503, that looks like exciting progress! Is it okay with you if I merge #30 into dev? Then you can try rebasing this work onto that. The rebase could be tricky in some places...if you are unsure about anything in my code feel free to ask.

kdw503 commented 7 years ago

Cody, Can I ask what #30? I can not find #30 in the issue list.

kdw503 commented 7 years ago

Now I understand. It is a pull request number. Yes, I am okay with the merge. I will rebase on that after merging.

Cody-G commented 7 years ago

The checklist in my first post is still relevant, though I just reworded the last item a little bit. I'm also creating a new issue and checklist that just focuses on the minimum we need in order to merge the "waveform" branch: #36

Cody-G commented 6 years ago

This seems done, woohoo!

kdw503 commented 6 years ago

Yeah! you did nice work!