search

HolyLab / Imagine

A graphical interface for recording with OCPI microscopes.
1 stars 1 forks source link

positionerSpeedCheck ERR_SHORT_WAVEFORM #49

Closed Cody-G closed 7 years ago

Cody-G commented 7 years ago

positionerSpeedCheck (and possibly other validation functions) require that the waveform have a minimum sample length. I think it's fine to enforce a minimum sample length on the entire sample sequence, but currently it looks like this function enforces that requirement on every named subsequence. I think this is too strict, and we should only enforce on the total sequence length. @kdw503 would this be okay with you?

For example, I am now testing a piezo command with total length greater than 1M samples, but there are subsequences inside of it that are only 50 samples long (this made it easier to script in combination with laser pulses). When I try running that command I get the ERR_SHORT_WAVEFORM code.

kdw503 commented 7 years ago

Yes, you are right. I also think this is too strict so I already remove this restriction and implemented and pushed.

Cody-G commented 7 years ago

Great, thanks! This is working better now :-)