HolyLab / Imagine

A graphical interface for recording with OCPI microscopes.
1 stars 1 forks source link

"Apply All" loop with dual cameras #52

Open Cody-G opened 6 years ago

Cody-G commented 6 years ago

In the waveform branch it seems that when I click "Apply All" for one camera, the other camera's settings get marked as changed (even though I did not change them). Then I click "Apply All" on the other camera and the first camera gets marked as changed, and so on in a loop...

So it's only possible to run both cameras simultaneously if I choose to "Go ahead without applying" the settings. This isn't a serious problem if one makes sure that the settings were applied at least once on both cameras and understands that it's okay to "go ahead without applying", but it's not optimal operation.

kdw503 commented 6 years ago

Ok. I will fix this.

Cody-G commented 6 years ago

This is mostly fixed; now I can run both cameras simultaneously, so the main problem is fixed. I say "mostly" because there's one unexpected behavior: When I load a waveform file that has instructions only for camera2 and then click "apply" I get an error message from the Imagine console. I think maybe it's trying to apply the camera settings to camera1? It's pretty much harmless because I can still click "apply" in the camera2 window and the recording runs correctly. But I think it's a bit confusing that an error message is shown in the camera1 window.

kdw503 commented 6 years ago

Ok. I'll check this.