search

Hopson97 / open-builder

Open "Minecraft-like" game with multiplayer support and Lua scripting support for the both client and server
https://github.com/Hopson97/open-builder/projects/3
GNU General Public License v3.0
700 stars 80 forks source link

Prevent water blocks being breakable #109

Closed Hopson97 closed 4 years ago

Hopson97 commented 4 years ago

BEFORE image

AFTER image

Also rename "meshType" to just "type" for voxels, as it more reflects what it is

b0guslaw commented 4 years ago

The way I understand it this PR does two things: Make water blocks unbreakable and prevent the selection box to render on water on blocks. The commit message does not reflect this appropriately, I recommend splitting it into two commits, or fix the commit message so it reflects both changes.

Also can you explain why meshType was renamed to type, whereas meshStyle did not undergo that change?

Hopson97 commented 4 years ago

Agreed about the commit message.

As for the renaming, the original name meshType was wrong, type makes more sense as it says what sort physical state the voxel is, for example a "solid" voxel, a "gas" voxel, or a "fluid" voxel. These have very little to do with the actual mesh of the voxel.

MeshStyle is correct as it says the style of the mesh. For example, blocks would have a "block" mesh style, whereas things like flowers and such would have an "X" shaped mesh style.

rehwinkel commented 4 years ago

I think it's good to merge!