search

Hopson97 / open-builder

Open "Minecraft-like" game with multiplayer support and Lua scripting support for the both client and server
https://github.com/Hopson97/open-builder/projects/3
GNU General Public License v3.0
703 stars 80 forks source link

Allow GitHub actions to recognize std::filesystem, std::optional etc #174

Closed Hopson97 closed 4 years ago

Hopson97 commented 4 years ago

Describe your suggestion

The current GitHub actions setup fails to build any code that uses certain C++17 features, such as std::filesystem and std::optional.

As a result of this I am reluctant to use these features, despite their usefulness.

Implementations ideas [optional]

I have tired to find a solution to this, but have not.

cedricschwyter commented 4 years ago

I have also had this problem for a long time now (in other projects as well). Also still desperately looking for a solution...

cedricschwyter commented 4 years ago

The thing is, you can try to reinstall the compilers with a version that supports this (g++-8 should suffice if I'm correct, not 100% sure, would have to check), but I have tried this in other projects and it somehow still does not work. See this job where I tried to upgrade the gcc and g++ compilers to version 8. I even exported the new values to the corresponding CC and CXX environment variables. CMake still identifies the compilers as GNU 7.5.0 which is unexpected...

cedricschwyter commented 4 years ago

Alright, I did some experimenting on one of my projects. I will propose an update for the automatic install script shortly, we'll see whether that does the trick, let us hope ;)

cedricschwyter commented 4 years ago

This can probably be closed now with #175 merged :)

Hopson97 commented 4 years ago

Thanks again :)