Hopson97 / open-builder

Open "Minecraft-like" game with multiplayer support and Lua scripting support for the both client and server
https://github.com/Hopson97/open-builder/projects/3
GNU General Public License v3.0
700 stars 80 forks source link

Doc building on Windows with Visual Studio #179

Closed gml16 closed 4 years ago

gml16 commented 4 years ago

Thank you for making the doc to build with Visual Studio. I think there are a couple of changes that may improve it:

I would happily make a pull request to add those items in the doc if you think they should be added. Especially for point 3, which way do you think is best: adding the pragma line in sol.hpp or mentioning in the doc to turn off warnings from this error?

Hopson97 commented 4 years ago

Hi thanks for this, if you could make a PR for these changes that would be amazing :) Point 2 is due to very recent changes, I had just not gotten around to changing the docs yet.

As for point 3, I think go with the #pragma warning(disable : 4996), as this is already being done for a different warning from some other dependency, and it means less steps in the guide which would be easier to follow.

Thanks!