Hopson97 / open-builder

Open "Minecraft-like" game with multiplayer support and Lua scripting support for the both client and server
https://github.com/Hopson97/open-builder/projects/3
GNU General Public License v3.0
700 stars 80 forks source link

Fix MacOS Build/build in general #200

Closed liz3 closed 4 years ago

liz3 commented 4 years ago

The first commit fixes the build for macOS which failed due to the usage of the undefined member window which was present as ctx

The Second commit disables Tests which fail to build due to Client having no default constructor without parameters. I did look at the two required params ClientWorld& and Player&, but it did not seam like the tests where easily fixable without reading deeper into the codebase.

If the comments should not be disabled the first commit could be cherry picked. But this PR builds error free on darwin and from casual testing the game seams to work as expected.