search

Hopson97 / open-builder

Open "Minecraft-like" game with multiplayer support and Lua scripting support for the both client and server
https://github.com/Hopson97/open-builder/projects/3
GNU General Public License v3.0
700 stars 80 forks source link

Set CMAKE_CXX_STANDARD to C++ 17 #71

Closed BrunoSilvaFreire closed 4 years ago

BrunoSilvaFreire commented 4 years ago

Setting the CMAKE_CXX_STANDARD variable to 17 warns the CMake generators about which C++ standart to use for generated build systems, as specified here and here.

This will probably also help to fix some issues that the wiki says Visual Studio has with CMake, IF, the MSVC version is later than 2015 Update 3.

Hopson97 commented 4 years ago

My CMakeLists do this already

https://github.com/Hopson97/open-builder/blob/f8a58ae8e18924d8aef6e04d7700244c086a6925/CMakeLists.txt#L10

BrunoSilvaFreire commented 4 years ago

Oh, did not see that, closing issue