Hopson97 / open-builder

Open "Minecraft-like" game with multiplayer support and Lua scripting support for the both client and server

https://github.com/Hopson97/open-builder/projects/3

GNU General Public License v3.0

700 stars 80 forks source link

Moire Effect #74

Open Hopson97 opened 4 years ago

Hopson97 commented 4 years ago

Bug Name

Moire Effect

Describe the bug

When looking in the distant, sometimes circles can appear on the terrain

To Reproduce

Just looks at things far away

Screenshots

Screenshot_20200113_065323

Desktop (please complete the following information):

OS: Windows 10, Ubuntu LTS

Additional context

Possibly caused by wacky texture parameters on the Texture Array object (found in src/client/gl/textures.cpp)

UglySwedishFish commented 4 years ago

This is not a bug per se, but an artifact that is caused by geometry aliasing. There is nothing you could do in the texture tweaking to solve this.

UglySwedishFish commented 4 years ago

As an additional pointer to this, if you really want to get rid of it I could attempt a rewrite of the entire rendering pipeline. But I don't think you're going to like the additional work you're going to have to do when you want to add additional simple things (like waving plants)

redinator2000 commented 4 years ago

Possible ways to dodge the issue:

use a different set of simpler textures for blocks >150 blocks away (probably will look worse)
use something like minecraft optifine's connected textures, use the top all-green texture on the side of grass blocks when there is another grass block 1 unit to the side and 1 unit down
for steep/high altitude terrain, generate a simpler textured block on the surface, like stone

rehwinkel commented 4 years ago

I believe simple MSAA can fix this issue.