Hotrian / OpenVRTwitchChat

Put your favorite Twitch Chat directly into any OpenVR game!
Other
174 stars 50 forks source link

Add subscriber/raid notifications, capture exception upon emote parsing failure. #35

Open DorCoMaNdO opened 4 years ago

DorCoMaNdO commented 4 years ago

Changes are untested.

DorCoMaNdO commented 4 years ago

@Hotrian any chance you could test this and release an update so that the people who still use this program could have a drag&drop fix?

Hotrian commented 4 years ago

Sure, if I get a chance I will give it a look, though I can't say for sure when I will have some time to test it out

DorCoMaNdO commented 4 years ago

Thank you.

I believe I know why the emote parsing fails, the modified emote ids appear to be appending a string to the id, despite normal emotes only ever using an integer, changing let emoteId = int.Parse(emote.Substring(0, emoteSplit)) to let emoteId = emote.Substring(0, emoteSplit) and changing the EmoteId variable of EmoteKey from int to string should do the trick.

Hotrian commented 4 years ago

Hey sorry it has taken me so long to go over this one. I still won't be able to test this for a couple of months as I am in the process of moving, and my VR setup is thus down currently. I should be able to test this in a month or two and integrate it along with changing the emote Id to being string compatible as some of the newer emotes have a string format instead of an integer format.