search

HumanCellAtlas / data-monitoring-dashboard

2 stars 1 forks source link

Decouple some of the complex logic from frontend #28

Closed rexwangcc closed 5 years ago

rexwangcc commented 5 years ago

As a developer of the data-monitoring-dashboard, before implementing further advanced features such as AuthN, I want to have some of the complex logic decoupled from the frontend, which will make the code base easier to maintain and evolve.

rexwangcc commented 5 years ago

To be clear, this could be done by just extracting the JS code to separate modules. Furthermore, we could leverage some modern frameworks to help build a more modular UI, such as Vue or React.

parthshahva commented 5 years ago

100%. The frontend as it stands right now is garbage. Its just a bunch of if statements I threw at the screen to get it to work. One of the next things I will be taking on is actually moving a lot of the frontend logic into the backend (with tests :)). This should simplify the frontend dramatically. We should then also move to a modern framework without a doubt. Good suggestions!

parthshahva commented 5 years ago

A lot of the of the logic was moved from the frontend to the backend. The javascript was also pulled out of the html file. Was there anything else you were thinking as part of this ticket @rexwangcc ?

rexwangcc commented 5 years ago

No, it looks much better now, thanks for the efforts on de-coupling!