search

IATI / IATI-Datastore

An open-source datastore for IATI data with RESTful web API providing XML, JSON, CSV plus ETL tools
http://datastore.iatistandard.org/
Other
1 stars 0 forks source link

Parser expects a `reporting-org` to be present, but this is not a required element in IATI 1.0x #270

Closed andylolz closed 6 years ago

andylolz commented 7 years ago

Here’s the offending bit of code.

For instance, all AFD activities fail to parse, so don’t appear on the datastore. The datastore complains that AFD activities (specifically, their hierarchy 1 activities) don’t always include a reporting-org - something that is required in IATI 2.x.

However, AFD publish to IATI 1.03, which does not require a reporting-org (in fact, this isn’t required for 1.0x). See – their data validates.

andylolz commented 6 years ago

AFD still don’t appear on the IATI datastore.

@dalepotter If I send a fix for this bug, how likely is it that it would be merged? I’m not going to spend time on it if it won’t be merged. But I’d also like one of the biggest IATI publishers to appear on the datastore.

andylolz commented 6 years ago

Steps to reproduce:

  1. Set up the datastore locally

  2. run:

    $ iati crawl dataset_list
$ iati crawl manual_update --dataset=afd-st
andylolz commented 6 years ago

This is closed, but continues to be broken. I don’t have the power to reopen it.

I think the code is correct and deployed, but possibly the datastore doesn’t attempt to reparse, since the data hasn’t changed since last time it failed (and the datastore doesn’t realise that its own code has been changed since last time). Something like that.