IATI / IATI-Datastore

An open-source datastore for IATI data with RESTful web API providing XML, JSON, CSV plus ETL tools
http://datastore.iatistandard.org/
Other
1 stars 0 forks source link

Add requires.io filters to requirements.txt #287

Closed hayfield closed 6 years ago

dalepotter commented 6 years ago

Tests are failing :-(

ImportError: No module named flask.ext.sqlalchemy._MapperSignalEvents

hayfield commented 6 years ago

Googling of the error message indicates that it means the tests are not running from within a virtualenv.

andylolz commented 6 years ago

This is a branch from requires-io-master, which is also failing tests (presumably because requires.io is updating packages on that branch without these sorts of filters!)

I think you’d be better off branching from master (where the build is passing) and adding these sorts of filters there.

andylolz commented 6 years ago

Googling of the error message indicates that it means the tests are not running from within a virtualenv.

FWIW if I create a new virtualenv locally, install the dev requirements on this branch, then run tests, I hit the same error message.

dalepotter commented 6 years ago

+1 for @andylolz 's suggestion of branching from master. I'd suggest creating a dev branch (to become the development branch). Then we can do away with the live branch on this repo too.

live appears to currently be in sync with master.

hayfield commented 6 years ago

Will create a new branch from master for these changes, then close this and #266

hayfield commented 6 years ago

(I'll leave the live -> master -> dev change to be a separate task since it has the potential to break things and there's no working Dev Datastore at the moment)

hayfield commented 6 years ago

288 does this in a hopefully-working manner (by removing months of not-OK changes).