search

IATI / IATI-Datastore

An open-source datastore for IATI data with RESTful web API providing XML, JSON, CSV plus ETL tools
http://datastore.iatistandard.org/
Other
1 stars 0 forks source link

Filter on transaction AND activity sector #299

Closed andylolz closed 6 years ago

andylolz commented 6 years ago

Fixes #284.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 49.309% when pulling f2dfe2f5295ff3173e7eeb1353fe41148e8d2d28 on andylolz:284-transaction-sectors into 841472a7702a790d3f6e7e211b723e0ed97a0719 on IATI:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 78.744% when pulling 734727130f0806ce68d329cf588148ff38200527 on andylolz:284-transaction-sectors into dbbc02bc8b8ac541b9df58961b2571d18b32b167 on IATI:master.

andylolz commented 6 years ago

This is a bit of a digression from the way datastore filters work… The more consistent approach here would have been to add a transaction_sector filter.

I’m not terribly keen on that approach, because it means running two queries every time you want to filter on sector (by activity sector, and by transaction sector).

Anyway – interested to hear if this is good / bad, or how it should be changed.

allthatilk commented 6 years ago

@andylolz this one needs updating too 🙂