search

IATI / IATI-Datastore

An open-source datastore for IATI data with RESTful web API providing XML, JSON, CSV plus ETL tools
http://datastore.iatistandard.org/
Other
1 stars 0 forks source link

Coverage should only include iati_datastore #304

Closed andylolz closed 6 years ago

andylolz commented 6 years ago

This excludes dependencies from coverage tests.

It also excludes all test files.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+29.4%) to 78.744% when pulling 7f12fd0ad916ebc1c2f9bd602559404fa2bb1fc2 on andylolz:fix-coverage into 5aecb8fcab1c0b720ef8056ec306ccf3de4ed8a6 on IATI:master.

andylolz commented 6 years ago

It’s worth running:

$ rm .coverage
$ nosetests iati_datastore --with-coverage
$ coverage html

…and taking a look at coverage in more detail.

andylolz commented 6 years ago

Current output of coverage report on this branch:

$ coverage report
Name                                                       Stmts   Miss  Cover
------------------------------------------------------------------------------
iati_datastore/iatilib/__init__                               16      8    50%
iati_datastore/iatilib/codelists/__init__                     34      2    94%
iati_datastore/iatilib/codelists/enum                         63      9    86%
iati_datastore/iatilib/console                                55     55     0%
iati_datastore/iatilib/crawler                               286    105    63%
iati_datastore/iatilib/frontend/__init__                      30      9    70%
iati_datastore/iatilib/frontend/api1                         159     45    72%
iati_datastore/iatilib/frontend/dsfilter                      99     11    89%
iati_datastore/iatilib/frontend/serialize/__init__            11      0   100%
iati_datastore/iatilib/frontend/serialize/csv                198      7    96%
iati_datastore/iatilib/frontend/serialize/jsonserializer      58     15    74%
iati_datastore/iatilib/frontend/validators                    22      0   100%
iati_datastore/iatilib/loghandlers                            21      1    95%
iati_datastore/iatilib/model                                 243     10    96%
iati_datastore/iatilib/parse                                 319     44    86%
iati_datastore/iatilib/queue                                  31     20    35%
iati_datastore/iatilib/wsgi                                    7      7     0%
iati_datastore/setup                                           4      4     0%
------------------------------------------------------------------------------
TOTAL                                                       1656    352    79%

I.e. just the iati_datastore folder, omitting tests.

andylolz commented 6 years ago

This just adds a dotfile. I don’t think it should have the “waiting for dev datastore” label. It seems like it could be merged in advance of that.

dalepotter commented 6 years ago

Looks good, as code in the alembic folder is not used in the iati_datastore.

andylolz commented 6 years ago

Great – thanks!