ICB-DCM / pyPESTO

python Parameter EStimation TOolbox
https://pypesto.readthedocs.io
BSD 3-Clause "New" or "Revised" License
216 stars 47 forks source link

PetabImporter: version-specific amici model directories #1283

Closed dweindl closed 7 months ago

dweindl commented 7 months ago

Use different directories for models from different amici versions (e.g., amici_models/0.20.0/{model_name} instead of amici_models/{model_name}). Allows switching between amici versions without version errors or re-importing the model.

(We could also include the architecture, if considered helpful.)

codecov-commenter commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7229c35) 84.33% compared to head (1b4f8d5) 67.85%.

Files Patch % Lines
pypesto/petab/importer.py 66.66% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1283 +/- ## ============================================ - Coverage 84.33% 67.85% -16.49% ============================================ Files 152 152 Lines 12420 12420 ============================================ - Hits 10474 8427 -2047 - Misses 1946 3993 +2047 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.