ICB-DCM / pyPESTO

python Parameter EStimation TOolbox
https://pypesto.readthedocs.io
BSD 3-Clause "New" or "Revised" License
216 stars 47 forks source link

Select: use petab_select method to set estimated parameters #1287

Closed dilpath closed 7 months ago

dilpath commented 7 months ago

Possibly a breaking change, if users expect scaled values at petab_select.Model.estimated_parameters, because PEtab Select stores unscaled parameters now.

codecov-commenter commented 7 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2ae9405) 79.16% compared to head (5700709) 41.50%.

Files Patch % Lines
pypesto/select/model_problem.py 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1287 +/- ## ============================================ - Coverage 79.16% 41.50% -37.67% ============================================ Files 153 153 Lines 12455 12455 ============================================ - Hits 9860 5169 -4691 - Misses 2595 7286 +4691 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.