search

ICB-DCM / pyPESTO

python Parameter EStimation TOolbox
https://pypesto.readthedocs.io
BSD 3-Clause "New" or "Revised" License
216 stars 47 forks source link

Semiquantitative: Robust regularization calculation #1297

Closed Doresic closed 7 months ago

Doresic commented 7 months ago

Making the analytical calculation of the optimal regularization robust to the simulation range. In case the range was 0, the optimal beta was infinite due to division by 0.

codecov-commenter commented 7 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (c35f199) 84.48% compared to head (7e18f9a) 84.37%.

Files Patch % Lines
pypesto/visualize/spline_approximation.py 0.00% 3 Missing :warning:
pypesto/hierarchical/semiquantitative/solver.py 66.66% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1297 +/- ## =========================================== - Coverage 84.48% 84.37% -0.11% =========================================== Files 153 153 Lines 12449 12455 +6 =========================================== - Hits 10517 10509 -8 - Misses 1932 1946 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Doresic commented 7 months ago

Not sure why the nbqa black run is failing. Locally it works. Will check again.

stephanmg commented 7 months ago

Looks like two formatters are run

stephanmg commented 7 months ago

Related to #1300