search

ICB-DCM / pyPESTO

python Parameter EStimation TOolbox
https://pypesto.readthedocs.io
BSD 3-Clause "New" or "Revised" License
216 stars 47 forks source link

Ruff codechecks #1307

Closed PaulJonasJost closed 6 months ago

PaulJonasJost commented 6 months ago

Most important to check would be

can flake8 be deleted from tox and .flake8 as well?

stephanmg commented 6 months ago

Most important to check would be

  • pre-commit-config.yaml
  • pyproject.toml

can flake8 be deleted from tox and .flake8 as well?

Looks good to me. Would remove .flake8.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 45.59322% with 321 lines in your changes are missing coverage. Please review.

Project coverage is 53.32%. Comparing base (f9231f2) to head (ce3c6e6).

:exclamation: Current head ce3c6e6 differs from pull request most recent head 4556bd0. Consider uploading reports for the commit 4556bd0 to get more accurate results

Files Patch % Lines
pypesto/visualize/sampling.py 0.00% 32 Missing :warning:
pypesto/result/predict.py 0.00% 18 Missing :warning:
pypesto/visualize/ensemble.py 0.00% 18 Missing :warning:
pypesto/objective/amici/amici.py 50.00% 16 Missing :warning:
pypesto/store/read_from_hdf5.py 40.90% 13 Missing :warning:
pypesto/ensemble/ensemble.py 0.00% 11 Missing :warning:
pypesto/ensemble/util.py 0.00% 10 Missing :warning:
pypesto/objective/priors.py 0.00% 9 Missing :warning:
pypesto/problem/base.py 50.00% 9 Missing :warning:
pypesto/visualize/dimension_reduction.py 0.00% 9 Missing :warning:
... and 52 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1307 +/- ## ============================================ - Coverage 84.27% 53.32% -30.96% ============================================ Files 153 153 Lines 12459 12456 -3 ============================================ - Hits 10500 6642 -3858 - Misses 1959 5814 +3855 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

FFroehlich commented 6 months ago

bit late now, but might make sense to add the PR of this commit to a .git-blame-ignore-revs file (see https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view)

PaulJonasJost commented 6 months ago

bit late now, but might make sense to add the PR of this commit to a .git-blame-ignore-revs file (see https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view)

might make sense to include yanks black changes back then as well 🤔