ICB-DCM / pyPESTO

python Parameter EStimation TOolbox
https://pypesto.readthedocs.io
BSD 3-Clause "New" or "Revised" License
216 stars 47 forks source link

Support ipopt with gradient approximation #1310

Closed MerktSimon closed 6 months ago

MerktSimon commented 6 months ago

Ipopt supports approximation of Jacobian/Gradients. With this PR pyPESTO will support it, too (fixes #1284).

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 78.04878% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 53.31%. Comparing base (312f43a) to head (d555910).

Files Patch % Lines
pypesto/optimize/optimizer.py 78.04% 9 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1310 +/- ## ============================================ - Coverage 83.14% 53.31% -29.83% ============================================ Files 153 153 Lines 12451 12459 +8 ============================================ - Hits 10352 6643 -3709 - Misses 2099 5816 +3717 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MerktSimon commented 6 months ago

just added a test. Not sure what the failing julia test has to do with it.