ICB-DCM / pyPESTO

python Parameter EStimation TOolbox
https://pypesto.readthedocs.io
BSD 3-Clause "New" or "Revised" License
216 stars 47 forks source link

Relative: Fix return of relative calculator if sim fails #1315

Closed Doresic closed 6 months ago

Doresic commented 6 months ago

In case of simulation fail, the inner relative calculator did not return inner parameters to be added to the inner result. This caused some ValueError: too many values to unpack (expected 2) as a tuple was expected.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 53.33%. Comparing base (82b7d5d) to head (0e166a8).

Files Patch % Lines
pypesto/hierarchical/relative/calculator.py 33.33% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1315 +/- ## ============================================ - Coverage 84.38% 53.33% -31.06% ============================================ Files 153 153 Lines 12456 12456 ============================================ - Hits 10511 6643 -3868 - Misses 1945 5813 +3868 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.