ICB-DCM / pyPESTO

python Parameter EStimation TOolbox
https://pypesto.readthedocs.io
BSD 3-Clause "New" or "Revised" License
207 stars 45 forks source link

ESSOptimizer: Respect local_n2 in case of failed initial local search #1328

Closed dweindl closed 4 months ago

dweindl commented 4 months ago

Fixes an issue where ESSOptimizer would try to repeatedly perform a local search from the best known value, instead of trying other promising points, in case the initial local search yields a non-finite result.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.40%. Comparing base (263b30e) to head (902cb34).

Files Patch % Lines
pypesto/optimize/ess/ess.py 50.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1328 +/- ## =========================================== - Coverage 84.43% 84.40% -0.03% =========================================== Files 153 153 Lines 12531 12533 +2 =========================================== - Hits 10580 10578 -2 - Misses 1951 1955 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.