ICB-DCM / pyPESTO

python Parameter EStimation TOolbox
https://pypesto.readthedocs.io
BSD 3-Clause "New" or "Revised" License
207 stars 45 forks source link

Semiquantitative: fix inner opt tolerance #1330

Closed Doresic closed 4 months ago

Doresic commented 4 months ago

The default tolerance for the inner optimization of semiquantitative observables was set too low. Setting it to the default L-BFGS-B tolerances.

Additionally, there was a small bug in the inner calculator collector: the quantitative_data_mask of the edatas was not taking into account that some entries of edatas can be nan. This led to some failures and nan values in the calculation of the quantitative result.