search

ICB-DCM / pyPESTO

python Parameter EStimation TOolbox
https://pypesto.readthedocs.io
BSD 3-Clause "New" or "Revised" License
207 stars 45 forks source link

pre-commit: pyupgrade #1352

Closed dweindl closed 3 months ago

dweindl commented 3 months ago

Stop using deprecated type annotations and imports.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 97.86096% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 84.32%. Comparing base (5879755) to head (be95d2b).

Files Patch % Lines
pypesto/objective/aesara/base.py 50.00% 2 Missing :warning:
pypesto/objective/julia/petabJl.py 0.00% 1 Missing :warning:
pypesto/visualize/sampling.py 83.33% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1352 +/- ## =========================================== + Coverage 84.25% 84.32% +0.06% =========================================== Files 157 157 Lines 12871 12911 +40 =========================================== + Hits 10845 10887 +42 + Misses 2026 2024 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dweindl commented 3 months ago

Add to ".git-blame-ignore-revs"?

Yes, but only after merging.

dweindl commented 3 months ago

👍 please add 64efde1 to https://github.com/ICB-DCM/pyPESTO/blob/develop/.git-blame-ignore-revs

After merge. Hash will change.

and use ruff (UP, https://docs.astral.sh/ruff/rules/#pyupgrade-up)

:+1: Didn't notice it was available through ruff.