search

ICB-DCM / pyPESTO

python Parameter EStimation TOolbox
https://pypesto.readthedocs.io
BSD 3-Clause "New" or "Revised" License
207 stars 45 forks source link

What's the purpose of `Ensemble.predictions`? #1357

Open dweindl opened 3 months ago

dweindl commented 3 months ago

I don't quite understand the purpose of Ensemble.predictions. Does anybody know what this was intended for? I don't find it really being used anywhere.

https://github.com/ICB-DCM/pyPESTO/blob/b50bc8fc1853002d845db80f7e2332cb410f92a6/pypesto/ensemble/ensemble.py#L509-L510

I would find it more plausible if some predictions would store a reference to the ensemble they were generated from, rather than the other way around. EnsemblePrediction claims to be doing that, but that's not the case:

https://github.com/ICB-DCM/pyPESTO/blob/b50bc8fc1853002d845db80f7e2332cb410f92a6/pypesto/ensemble/ensemble.py#L59-L64

PaulJonasJost commented 3 months ago

Agreed, quickly went through the codebase and it seems to be not used unless to allow functions that use get_prediction_dataset to be called with an ensemble. Should be changed. Fine with removing and would do it if others also agree. I think this is confusing. Would also add the ensemble as reference to the EnsemblePRediction.