search

ICB-DCM / pyPESTO

python Parameter EStimation TOolbox
https://pypesto.readthedocs.io
BSD 3-Clause "New" or "Revised" License
207 stars 45 forks source link

Correlation plot with nans #1365

Closed PaulJonasJost closed 2 months ago

PaulJonasJost commented 3 months ago

Added a test. There was previously an error, when "all" start indices were selected, where no general checks were run.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.51%. Comparing base (3edf785) to head (dcb1a06).

Files Patch % Lines
pypesto/visualize/misc.py 77.77% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1365 +/- ## =========================================== + Coverage 84.42% 84.51% +0.08% =========================================== Files 157 157 Lines 12928 12931 +3 =========================================== + Hits 10915 10928 +13 + Misses 2013 2003 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stephanmg commented 3 months ago

We should also think about adding a warning or logging entry that some start indices were removed from plotting due to infinite values (if that's the case). That's, for instance, done in the parameters.py plotting routine.

Could that be as simple as a string message / status with: "Removed XY entries due to infinite or NaN value"?