Closed Doresic closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 53.72%. Comparing base (
3b1a12f
) to head (b057c50
).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
If an observable has hierarchical noise, but has no measurement at some simulation timepoint for which the model is simulated, then the
edata.getObservedData
will benan
but therdata.sigmay
for that condition, observable and timepoint will be 0.This was causing an issue in the direct calculation of the NLLH as we were taking the
log(2 * np.pi * sigma_i**2)
wheresigma_i
wasrdata.sigmay
. This gaveRuntimeWarning: divide by zero encountered in log
errors.The fix is simple: mask the
sigma_i
array with the mask for which the data is notnan
. Already available inproblem.data_mask
.Was raised in issue #1375