Closed PaulJonasJost closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.52%. Comparing base (
18be6e3
) to head (c97d36c
).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
As the doctoring already explained before, we usually want
problem.x_fixed_vals
as defaults if we update a vector x. I think this should be a default and leaving the nans should be left for gradients (hence another parameter to distinguish the two.