search

ICB-DCM / pyPESTO

python Parameter EStimation TOolbox
https://pypesto.readthedocs.io
BSD 3-Clause "New" or "Revised" License
206 stars 44 forks source link

Fixing Aggregated Objective Visualisations #1411

Closed arrjon closed 3 weeks ago

arrjon commented 1 month ago

Fixes the isses mentioned in #1410 so AggregatedObjective can be used in the visualize.model_fit function.

codecov-commenter commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 65.21739% with 16 lines in your changes missing coverage. Please review.

Project coverage is 83.85%. Comparing base (f183b3c) to head (0f63738).

Files Patch % Lines
pypesto/visualize/model_fit.py 64.44% 16 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1411 +/- ## =========================================== - Coverage 83.89% 83.85% -0.05% =========================================== Files 160 160 Lines 13067 13096 +29 =========================================== + Hits 10963 10982 +19 - Misses 2104 2114 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arrjon commented 4 weeks ago

For the moment I iterate over the objectives in AggregatedObjectives to find all amici models and plot them individually. For the case with only one model and a NegLogPrior objective this works fine.

However, I did not test the function using a petab problem with multiple amici models. Potentially, one needs to extract information from the petab measurement file specific to the corresponding model.