ICB-DCM / pyPESTO

python Parameter EStimation TOolbox
https://pypesto.readthedocs.io
BSD 3-Clause "New" or "Revised" License
206 stars 44 forks source link

AmiciObjective: For sensi_orders>0, check that sensitivities wrt all relevant parameters are computed #1414

Open dweindl opened 3 weeks ago

dweindl commented 3 weeks ago

Related to https://github.com/AMICI-dev/AMICI/issues/2455

When we have an AmiciObjective and need to compute gradients, we should make sure that sensitivities can be computed w.r.t. all free parameters (this needs to be checked when constructing AmiciObjective, and whenever additional parameters are ixed). I.e. we need to check whether all non-fixed parameters exist in amici_model.getParameterIds(), taking into account AmiciObjective.parameter_mapping.

This is particularly important for PEtab import, where we aren't necessarily able to compute sensitivities w.r.t. to all parameters (https://github.com/AMICI-dev/AMICI/pull/2456).