Closed dilpath closed 5 days ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 93.75000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 83.35%. Comparing base (
5a8e014
) to head (b9ec235
).
Files | Patch % | Lines |
---|---|---|
pypesto/objective/aggregated.py | 83.33% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
An alternative fix would be to always pass
return_dict
tocall_unprocessed
. This would be fine for me, but might break someone's custom objective.
I think this would make sense. Your current implementation would already enable issuing a DeprecationWarning and updating things accordingly.
An alternative fix would be to always pass
return_dict
tocall_unprocessed
. This would be fine for me, but might break someone's custom objective.I think this would make sense. Your current implementation would already enable issuing a DeprecationWarning and updating things accordingly.
Thanks, I decided to simply switch to it by default now, with a DeprecationWarning
.
AmiciObjective
previously returned all AMICI RData information whenreturn_dict=True
. However, this was handled via__call__
. If the PEtab problem has a prior, then anAggregatedObjective
is created, with anAmiciObjective
and the prior inside. TheAggregatedObjective
callscall_unprocessed
of each internal objective, skippingAmiciObjective.__call__
and hence one would see something like:This PR changes the above to
i.e., rdatas are now "full" and e.g. plotting is now possible.
An alternative fix would be to always pass
return_dict
tocall_unprocessed
. This would be fine for me, but might break someone's custom objective.