Closed dilpath closed 4 days ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 83.33333%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 83.34%. Comparing base (
10d6092
) to head (ef1ac7a
).
Files | Patch % | Lines |
---|---|---|
pypesto/objective/amici/amici.py | 80.00% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
result.x = None
if simulation fails at the startpoint.result.x
is used to compute hierarchical inner parameters after optimization. Whenresult.x = None
, an AMICI simulation to compute inner parameters is still run, unexpectedly... I didn't look deeper there, but this PR stops the computation of inner parameters if simulation fails at the startpoint (defined byresult.x = None
).This PR means users do not see
NaN in p
AMICI simulation errors due toresult.x = None
. This can be confusing for users, who then try (and fail) to reproduce those errors withobjective(result.x0)
.