ICB-DCM / pyPESTO

python Parameter EStimation TOolbox
https://pypesto.readthedocs.io
BSD 3-Clause "New" or "Revised" License
222 stars 47 forks source link

CI: don't cache amici; pytest ignore amici_models; passenv BNGPATH #1523

Closed dweindl closed 1 hour ago

dweindl commented 3 hours ago
codecov-commenter commented 3 hours ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.79%. Comparing base (6eb4245) to head (b647f53).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1523 +/- ## =========================================== - Coverage 82.83% 82.79% -0.04% =========================================== Files 163 163 Lines 13962 13962 =========================================== - Hits 11565 11560 -5 - Misses 2397 2402 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dweindl commented 1 hour ago

What do we need a BNGPATH for? It is for bionetgen but I am not entirely aware here we use it.

Yes, for BioNetGen, which is used by pysb.

Also used here: https://github.com/ICB-DCM/pyPESTO/blob/3b97e345b63b33297a0dbf7844f68328cc9a378b/test/petab/test_petab_import.py#L23-L29