search

ICB-DCM / pyPESTO

python Parameter EStimation TOolbox
https://pypesto.readthedocs.io
BSD 3-Clause "New" or "Revised" License
216 stars 47 forks source link

`x_fixed_vals` and `x_fixed_indices` should be encoded as dict #421

Open FFroehlich opened 4 years ago

FFroehlich commented 4 years ago

uhm regarding x_fixed_vals and x_fixed_indices, I think it would be much cleaner if they were combined into a single dict {x_name: value}. Would make assignment less error prone, would avoid index wrangling and would be overall more pythonic.

yannikschaelte commented 4 years ago

When using x_names for anything but visualization, I would advocate adding a vector x_ids for identification, as in petab.

In principle fine for me to change this (would be an API change.) Sometimes, the separate specification of ixs and values may be more convenient, not sure whether one wants to allow both ways?