ICB-DCM / pyPESTO

python Parameter EStimation TOolbox
https://pypesto.readthedocs.io
BSD 3-Clause "New" or "Revised" License
216 stars 47 forks source link

Profile analysis routine #451

Open paulstapor opened 4 years ago

paulstapor commented 4 years ago

Profile likelihood results are not necessarily easy to interpret. Yet, having worked with them for a while, one can read a lot out of bad results. It would be really, really cool to have a routine such as "analyze_profiling_results", which checks profile likelihood results, pinpoints possible issues, and suggests (based on stored optimization options) changes in the options for each profile. Ideally, a second routine could be run which just applies these change and reruns profiling, in order to get better results... This routine could give scores to computed profiles, based on how many too high angles there are in a profile, how many drops in posterior ratio, how many optima were found, how many parameters run into bounds, etc... This could furthermore be nicely integrated with CI: i.e., changes to pyPESTO should not decrease the computed profile quality scorein an integration or a unit test (rather integration test to have something meaningful).

One far day, when I really have time, I would be happy to implement this... Only 36 years left to retirement...

yannikschaelte commented 4 years ago

Only 36 years left to retirement...

Sorry to break the news, but by that time retirement age must be >75 at least already.

Agreeing with the other points. At least a "analyze my profiles, tell me what is identifiable, or where potential flaws are" would be good.

paulstapor commented 4 years ago

I would imagine such a routine to do the following: Follow a profile and check:

...And so on... Who wants to implement it? :D

paulstapor commented 4 years ago

Ah, right: And finally plot profile with red highlighting of the bad segments, potentially with clickable comments...