search

IDA-RE-things / Chrome-xp-api-adapter

lighweight and fine-tuned unofficial alternative of progwrp.dll for Supermium/Thorium browsers, running on XP
11 stars 0 forks source link

discord issue with v1.2.0.5036 #7

Closed rereser closed 6 months ago

rereser commented 6 months ago

discord "aw snap" crash. to reproduce in supermium r4 on win xp sp3. go to https://legacyupdate.net/ click the community discord link and accept the invite. with version 1.2.0.5036 the page will crash. with version 1.2.0.5035 it does not.

IDA-RE-things commented 6 months ago

Hmm.... Ok. thanks for testing. Will check whats happened. I will disable downloads in such case while. While I'm' have not fixed this.

IDA-RE-things commented 6 months ago

BTW, is it created any crashdumps (*.dmp) under "Supermium_UserData\Crashpad\reports\" ? I can't reproduce while.

IDA-RE-things commented 6 months ago

Its should be able to attach this .dmp as attachnent. I still can't reproduce this, because having no discrod and discord account. It works on other sites for me. Need a crashdump.

rereser commented 6 months ago

another thing i noticed. with v1.2.0.5035 the bookmark i have to a discord channel is a blue circle with a red dot. that red dot will change to numbers if there are unread messages. with v 1.2.0.5036 that bookmark icon is missing the red dot. don't know if this helps, have limited knowledge how discord and github work. you will need to register on discord to reproduce i think. thorium will also crash with it's default progwrp.dll.

IDA-RE-things commented 6 months ago

I have found the problem in crashdump. But because it was optimized, all functions have one address (by my design have minimized size). So I created less optimized build (5037 in releases). You should run it, and send crashdump, created with this build.

thorium will also crash with it's default progwrp.dll.

So the Thorium will also crash with it's default progwrp.dll ? Its strange.

rereser commented 6 months ago

same problem with v1.2.0.5037.

IDA-RE-things commented 6 months ago

Try build 5038. Should be fixed now. Also the problem with bookmark color may be fixed.

rereser commented 6 months ago

v1.2.0.5038 fixed the issue. discord bookmark icon with the red dot is also good now. thank you for your amazing work and the fast response. this dll makes a huge difference in supermium r4 load time. it also seems to resolve the frequently hanging chrome processes on browser exit with the default supermium 1.1.0.5010 dll.

edit: issue also fixed in v1.2.0.5039 what version to use and should i close the issue?

IDA-RE-things commented 6 months ago

the buid 5039 has more fine-tuning, done by optimizer. You can use what you want. No other changes made.

Yes, you can close the issue.

rereser commented 6 months ago

thanks again. will use v1.2.0.5039 for now. issue closed.