IFRCGo / go-web-app

GO Web application! GO is a Red Cross Red Crescent platform to connect information on emergency needs with the right response.
https://go.ifrc.org
MIT License
8 stars 1 forks source link

Country Pages [Feedback and Issues] #360

Open udaynwa opened 11 months ago

udaynwa commented 11 months ago

Ticket description

If you find issues or have any feedback on the Country Pages, please add them in the comments. While commenting, please add them with Task list/ checkboxes (and with screenshots and URLs if possible).

Post-release changes

Hide PII in Local Units Information

Add Wiki hook points (29th April)

Additional changes (22nd April)

Feedback from Daniel added in the comments of IFRCGo/go-web-app#492

Commented by Daniel (4th March)

Additional feedback by Daniel (4th March)

Additional feedback (12th March)

26th March

Based on https://github.com/IFRCGo/go-web-app/issues/360#issuecomment-2009765400

8th April

17th April (Based on feedback from Mariam & Alex)

tovari commented 8 months ago

@udaynwa, When it is deployed to staging, would you mind to provide the dev and english string list to make the translations to es, fr and ar?

tovari commented 8 months ago

@udaynwa, can we also have a list of external sources implemented on country pages? Those will need to be added to the monitoring page. Thanks!

barshathakuri commented 8 months ago

@udaynwa, can we also have a list of external sources implemented on country pages? Those will need to be added to the monitoring page. Thanks!

Hi @tovari, These are the lists of external sources implemented on country pages for each component:

cc: @udaynwa

tovari commented 8 months ago
We will need to redirect the old tab urls to the new structure: Old url New url
/operations /ongoing-activities/emergencies
/three-w/projects /ongoing-activities/three-w/projects
/three-w/ns-projects /ns-overview/activities
/risk-watch /profile/risk-watch
/preparedness /ns-overview/capacity
/plan /ns-overview/strategic-priorities
/additional-info /additional-info
udaynwa commented 8 months ago

@tovari , your feedbacks on Country Pages have been incorporated and pushed to Staging as well. (except for the redirection to the new structure).

cc @samshara @frozenhelium

tovari commented 8 months ago

NS overview - Context and structure page can't be loaded: https://go-stage.ifrc.org/countries/82/ns-overview/context-and-structure

TypeError: Cannot read properties of undefined (reading 'value') at https://go-stage.ifrc.org/7.1.0/chunk-index.C_zihyfz.js:1:9910 at https://go-stage.ifrc.org/7.1.0/chunk-index.9UPBigen.js:1:2370 at Array.map () at P (https://go-stage.ifrc.org/7.1.0/chunk-index.9UPBigen.js:1:1808) at Bg (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:38:19519) at jh (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:40:3139) at FS (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:40:44804) at MS (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:40:39766) at LO (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:40:39694) at Qu (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:40:39547) at Kh (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:40:35914) at AS (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:40:34865) at b (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:25:1542) at MessagePort.L (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:25:1904)

tovari commented 8 months ago

NS overview - Context and structure page can't be loaded: https://go-stage.ifrc.org/countries/82/ns-overview/context-and-structure

TypeError: Cannot read properties of undefined (reading 'value') at https://go-stage.ifrc.org/7.1.0/chunk-index.C_zihyfz.js:1:9910 at https://go-stage.ifrc.org/7.1.0/chunk-index.9UPBigen.js:1:2370 at Array.map () at P (https://go-stage.ifrc.org/7.1.0/chunk-index.9UPBigen.js:1:1808) at Bg (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:38:19519) at jh (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:40:3139) at FS (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:40:44804) at MS (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:40:39766) at LO (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:40:39694) at Qu (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:40:39547) at Kh (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:40:35914) at AS (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:40:34865) at b (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:25:1542) at MessagePort.L (https://go-stage.ifrc.org/7.1.0/entry-index.h3y9Xjay.js:25:1904)

It works now. Not sure what happened.

frozenhelium commented 8 months ago

@tovari There was an issue in the previous version (v7.1.0) which is now fixed in the (v7.1.1)

tovari commented 8 months ago

A few things to improve:

udaynwa commented 8 months ago

@tovari

we shouldn't have GDACS events as emergencies. Not sure why do we generate emergencies from GDACS alerts

  • For this, this was in the Figma prototype. Therefore, we implemented a new API to fetch GDACS events, and created the view to show them. Should we remove this section altogether?

Active Operations under Ongoing Activities - Ongoing Emergencies doesn't show ongoing operations like https://go-stage.ifrc.org/emergencies/6647/details or https://go-stage.ifrc.org/emergencies/6646/details

Ongoing Activities - 3W Projects -> All Projects above the map (left side) should be renamed to Ongoing Projects

  • We will create a ticket and implement it.

Country profile - Overview: Missing data should be indicated by '-' as in most places except for Pop under 18 : https://go-stage.ifrc.org/countries/119/profile/overview

  • We will create a ticket and implement it.

cc @barshathakuri @samshara

tovari commented 8 months ago

Country profile - Overview: Missing data should be indicated by '-' as in most places except for Pop under 18 : https://go-stage.ifrc.org/countries/119/profile/overview

might be misleading. I mean we should have '-' at Pop under 18 as well.

steph-gm commented 8 months ago

NS Preparedness

However, once clicking on "view" inside these cards, the next page (of the specific cycle) should change according to the permissions. If public (not logged in), they should see something like the one that is already on Production, with limited access:

image
tovari commented 8 months ago
udaynwa commented 8 months ago

@tovari @steph-gm , thank you for adding your feedback. We are looking into them.

tovari commented 7 months ago

@frozenhelium, @samshara I'm sharing the translation strings here

country_pages_translations-240319.xlsx

mariam-yu commented 7 months ago

@tovari @udaynwa @frozenhelium Some updates to the country wires were requested. The wires have been updated (pending a final glance through by Alex). We still need to update the UI. The list of changes below so that they are easier to locate. Thanks! https://www.figma.com/proto/H9mZfGeXtlzK6HPzttYoci/IFRC-GO---Wires-Current---1?page-id=0%3A1&type=design&node-id=82-25714&viewport=11515%2C13586%2C0.14&t=Xv4cL6Q8FXtpcEBz-1&scaling=scale-down-width&starting-point-node-id=1%3A10724&hide-ui=1

Country changes list:


1 - NS overview > NS activities:

2 - NS overview > Context & Structure:

3. NS overview > Strategic Priorities:

4. NS overview > Capacity:

5. NS overview > Supporting Partners:

5. Country Profile > Supporting Partners:

6. Update text

mariam-yu commented 7 months ago

Here is the info for Point 2, bullet 2 from the above - hover texts (from @AlexxxH ):

• Home Government: (in pdf blank, no hover needed) • Foreign Government: Other governments and government departments from outside the country. This includes the EU. Examples are: UK (DFID/FCO), US (USAID/OFDA/OTI/PRM), Sweden (SIDA) etc. • Individuals: Members of the public, including funds from membership, major donors and legacies. • Corporations: Including donations, proceeds from joint promotions or sponsorship. • Foundations: Funds from a "not for profit" set up with the explicit aim of making donations to other organisations (e.g., Charities Aid Foundation). This includes foundations established by corporations or individuals (e.g., Lebara Foundation and Bill & Melinda Gates Foundation). • UN Agencies and other Multilateral Agencies: These include the development institutions of the UN (e.g., UNDP), the World Bank, Global Fund and regional development banks. • Pooled funds: Mechanisms used to receive contributions from multiple financial partners (mainly government donors) and allocate such resources to multiple implementing entities. Humanitarian pooled funds can be global (the START Fund) or country-based (e.g., the CHF, ERF). • Non-governmental organizations: Local and international "not for profit" civil society organizations independent from states and international governmental organizations. • Service income: Income linked to the provision of public services; for example, blood, hospital or ambulance services, search and rescue, etc. • Income generating activity: Income linked to the sale of a product or service; for example, commercial first aid training, retail, sale and/or rental of other products and services. • Other National Society: (in pdf blank, no hover needed) • IFRC (HQ, regional and countries delegations): (in pdf blank, no hover needed) • ICRC: (in pdf blank, no hover needed) • Other: Income that does not come from any of the above categories.

samshara commented 7 months ago

@mariam-yu, for the following tasks, we need the tooltip descriptions. Right now we don't see any.

  • Tooltip next to title "Strategic priorities" to explain what those are.
  • Adding a tooltip next to title "Membership Coordination" to explain that the section comes to Unified Planning and details.
mariam-yu commented 7 months ago

@AlexxxH Do you have any idea for the above? I guess a one-liner to explain what the SPs are and that they come from the UP. I'd put the same popup for both tooltips.

AlexxxH commented 7 months ago

@mariam-yu Hmm no I don't know, I'll ask Rania

tovari commented 7 months ago

Thanks for the updates, I discovered some issues:

samshara commented 7 months ago

@tovari

  • [ ] NS Overview - NS Acitivies: the map shows domestic projects instead of International projects of the NS

we fetch the projects using the following query https://goadmin-stage.ifrc.org/api/v2/project/?limit=9999&reporting_ns=81 Here, we use the reporting_ns query parameter to determine the international projects of a particular National Society (NS). The above situation arises when some projects are operated within the same National Society.

We could proceed with the following two ways

  1. Keep the view as it is and perhaps change the heading from 'NS International Activities' to 'NS Activities' to accurately reflect the data.
  2. Remove the projects that are operated within the same National Society. This will also mean that these projects won't be visible.

How do we proceed?

AlexxxH commented 7 months ago

@samshara @tovari @mariam-yu I would suggest the first option, so that we can keep domestic activities?

tovari commented 7 months ago

Ok, lets rename it to 'NS Activities'

mariam-yu commented 7 months ago

@

@samshara @tovari @mariam-yu I would suggest the first option, so that we can keep domestic activities?

@samshara @tovari @AlexxxH I think we had renamed it to NS Activities sometime back. Wires for reference: https://www.figma.com/file/H9mZfGeXtlzK6HPzttYoci/IFRC-GO---Wires-Current---1?type=design&node-id=82-30343&mode=design&t=0aM4N0RARK3shjGg-4

samshara commented 7 months ago

@

@samshara @tovari @mariam-yu I would suggest the first option, so that we can keep domestic activities?

@samshara @tovari @AlexxxH I think we had renamed it to NS Activities sometime back. Wires for reference: https://www.figma.com/file/H9mZfGeXtlzK6HPzttYoci/IFRC-GO---Wires-Current---1?type=design&node-id=82-30343&mode=design&t=0aM4N0RARK3shjGg-4

@mariam-yu I believe we need to appropriately rename the map section heading and the table heading as well.

AlexxxH commented 6 months ago

Hi everyone, here are the requested updates. The list looks long but that is (partly) becuase I strcutured it by section. Let me know if anything is unclear or you need more information. Thanks!

Sources - updating text and links:

Page-specific updates:

GO generic:

udaynwa commented 6 months ago

Risk Watch: Where there is not a source, please set the source to ""IFRC Montandon, Global Crisis Data Bank" (no link).

@AlexxxH , do we add the source information to every section in the Risk Watch?

cc @tovari @mariam-yu

AlexxxH commented 6 months ago

@udaynwa Yes please, but currently (based on the wireframes) the only sections without a source on the Risk Watch page are Average Risks by Month and Expected Return Periods

samshara commented 6 months ago

@AlexxxH , also, we are missing the source link for Risks by Months section. Can you please share them here?

AlexxxH commented 6 months ago

@samshara there are sources for this section in the wireframes (screenshot below), @mariam-yu are these still correct? image

samshara commented 6 months ago

@AlexxxH , Thanks. However, I don't know what URLs we use for the above sources ? The URLs are not attached in the figma file as well.

cc @mariam-yu

mariam-yu commented 6 months ago

Hey guys @AlexxxH @samshara @udaynwa the sources are not accurate in the wires yet. Let me update them this afternoon based on the chat with Alex. Otherwise, the wires are good to go. We are updating the UI.

mariam-yu commented 6 months ago

Hey guys @AlexxxH @samshara @udaynwa the sources are not accurate in the wires yet. Let me update them this afternoon based on the chat with Alex. Otherwise, the wires are good to go. We are updating the UI.

@udaynwa Country wires are up to date. UI in process. All the sources added. Let me know if you have any questions. @AlexxxH Let me know if we missed anything. Thanks!

https://www.figma.com/proto/H9mZfGeXtlzK6HPzttYoci/IFRC-GO---Wires-Current---1?page-id=0%3A1&type=design&node-id=82-25714&viewport=22827%2C23425%2C0.29&t=wNULCOt1mZY2WQzb-1&scaling=scale-down-width&starting-point-node-id=1%3A10724&hide-ui=1

samshara commented 6 months ago

image

Thanks for the quick updates on wires @mariam-yu. Is the source information in the above correct?

mariam-yu commented 6 months ago

@samshara I think so. Per @AlexxxH for all the risk stuff we should put crisis data bank without a link. @AlexxxH I think this was per chat with Justin. Is it ok to already put them like this? I added to all the risk tables.

tovari commented 6 months ago

Would you mind to add Wiki hook points on each page (sub-tab) as listed here? The icon could be located as usual on the right side.

PROD page url En | Wiki url EN /countries/XXX/ongoing-activities/emergencies | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#on-going-activities /countries/XXX/ongoing-activities/three-w/projects | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#h-3w-projects /countries/XXX/ns-overview/activities | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#national-society-overview /countries/XXX/ns-overview/context-and-structure | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#context-and-structure /countries/XXX/ns-overview/strategic-priorities | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#strategic-priorities /countries/XXX/ns-overview/capacity | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#capacity /countries/XXX/ns-overview/supporting-partners | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#partners /countries/XXX/profile/overview | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#country-profile /countries/XXX/profile/risk-watch | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#risk-watch /countries/XXX/profile/previous-events | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#previous-events /countries/XXX/profile/additional-info | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#additional-data

davidmuchatiza commented 6 months ago
image

There is a need to update the local units' information on the tooltip (both on the local units and health sites map) to exclude personal identifiable information, as the local unit map will be accessed by users who are not logged in. And here is the ticket

tovari commented 6 months ago
image

There is a need to update the local units' information on the tooltip (both on the local units and health sites map) to exclude personal identifiable information, as the local unit map will be accessed by users who are not logged in. And here is the ticket

@davidmuchatiza, only for the public access, or also for logged-in users?

davidmuchatiza commented 6 months ago
image

There is a need to update the local units' information on the tooltip (both on the local units and health sites map) to exclude personal identifiable information, as the local unit map will be accessed by users who are not logged in. And here is the ticket

@davidmuchatiza, only for the public access, or also for logged-in users?

For all the users for now, then maybe later on we can add more details for Logged-in users..

davidmuchatiza commented 6 months ago

Local Unit map tooltip title is using local names (Name_LOC), but we have some local units where only english names (Name_EN) are available and there's no local name provided. I'd like to suggest a solution to continue using Local names (Name_LOC) where available, but if they're blank, we should display the english names (Name_EN) instead. @udaynwa

justinginnetti commented 6 months ago

Small fixes:

Screenshot 2024-04-30 at 11 35 57

At the moment, the text here should read: "Source: UNDRR, World Bank/GFDRR and IDMC"

justinginnetti commented 6 months ago

Small fix. The text should read: "Sources: INFORM for each country's level of risk UNDRR for the population exposure IDMC for the expected displacements IPC for food insecurity"

Screenshot 2024-04-30 at 11 41 03
justinginnetti commented 6 months ago

Small fix. It should read:

"Sources: INFORM for each country's level of risk UNDRR for the population exposure IDMC for the expected displacements IPC for food insecurity"

Screenshot 2024-04-30 at 11 41 51
tovari commented 6 months ago

@udaynwa, there is an error when loading the NS Overview -> Partners page (e.g. here: https://go.ifrc.org/countries/206/ns-overview/partners

Not all countries are affected, but I couldn't find the root cause. We will need a fix for this on 02.05. Thanks!