search

IHTSDO / snomed-query-service

An implementation of the SNOMED CT Expression Constraint Language.
Other
26 stars 9 forks source link

Descendant of Attribute type does not seem to work #2

Open kaicode opened 8 years ago

kaicode commented 8 years ago

These should not return the same results: http://localhost:8080/concepts?ecQuery=<<73211009:47429007= http://localhost:8080/concepts?ecQuery=<<73211009:<47429007=

amanlig commented 6 years ago

HI @kaicode , does this still need work?

kaicode commented 6 years ago

@amanlig Yes, it still needs work. I've just corrected the queries in the example to make 47429007 |Associated with (attribute)| the attribute. I've rerun those against the July 2017 International release and the service gives the same 16 concepts back which is not correct.

amanlig commented 6 years ago

Thanks @kaicode. Can I have a shot at it and submit a fix?

kaicode commented 6 years ago

Hi @amanlig that would be very helpful, yes please! Could I please ask that you include a unit test which supports your fix. That would make it easy for us to accept your work and will ensure that this bug doesn't happen again. Many thanks.

amanlig commented 6 years ago

Will do add unit test with it. Thanks @kaicode.

mkaehlershs commented 3 years ago

is it planned to fix this bug? In the current version this bug is still present:

kaicode commented 3 years ago

We are not proactively maintaining this project because our main ECL implementation is within the Snowstorm project and we only have limited capacity. We are making some changes to this project related to our validation processes which use this as a library for MRCM validation. We welcome contributions from the community for any bug fixes.

Kind regards, Kai Kewley