IKIM-Essen / uncovar

Transparent and robust SARS-CoV-2 variant calling and lineage assignment with comprehensive reporting.
https://ikim-essen.github.io/uncovar
BSD 2-Clause "Simplified" License
21 stars 8 forks source link

feat: rule and script bed_to_bedpe #447

Closed AKBrueggemann closed 2 years ago

AKBrueggemann commented 2 years ago

Description

A rule and a script for converting a .bed file containing information about the primer into a .bedpe file. The .bedpe file format is used in the workflow. ## Related Issue #381 ## Checklist
thomasbtf commented 2 years ago

Nice work 👍 I think we should place the ARTIC V3 default prime bed file in the resources and make it adjustable via the config. So anybody can adjust the primer scheme given to the workflow. What do you think?

AKBrueggemann commented 2 years ago

So you mean that in the config there should be the path to the bed file? And should the path to the bedpe file stay in the config?

thomasbtf commented 2 years ago

The path to the .bed file in the config is probably enough because the workflow will generate the .bedpe.

thomasbtf commented 2 years ago

Looks good to me. @alethomas, what do you think about this? Folker wants us to look more closely at the PR and changes to the code.

thomasbtf commented 2 years ago

Maybe the docs should be updated and explain how to use a custom primer file. Best placement would be probably here.

thomasbtf commented 2 years ago

That is actually a good idea. However, then we have to think about handling "local" primer files via then config. It could be the case, that doesn't want to use the ARTIC primers or primer files, that are only downloadable via a URL.

Maybe add a function that checks if the entry in the config is a URL or a path. Upon this check, the file is either downloaded or locally found.

What do you think?

thomasbtf commented 2 years ago

@alethomas, @AKBrueggemann: What do you think?

alethomas commented 2 years ago

I really like this idea, @AKBrueggemann ?

AKBrueggemann commented 2 years ago

Alright, I'll change it, it is a good idea :)

thomasbtf commented 2 years ago

@alethomas Could you please also review? :)