IKIM-Essen / uncovar

Transparent and robust SARS-CoV-2 variant calling and lineage assignment with comprehensive reporting.
https://ikim-essen.github.io/uncovar
BSD 2-Clause "Simplified" License
21 stars 8 forks source link

chore: checkout full history for formatting #668

Closed johanneskoester closed 1 month ago

johanneskoester commented 1 month ago

Description

Related Issue

Checklist

huzuner commented 1 month ago

Conda command is not being found in some technology tests and in one benchmark test Could this also be about the recent conda change on snakemake?

johanneskoester commented 1 month ago

@alethomas unexpected failures here. Seems like a bug in pangolin's internal usage of the snakemake api.

johanneskoester commented 1 month ago

Ok, I think I found the problem. Seems to be fixed in the latest pangolin release.

johanneskoester commented 1 month ago

However, this is not yet merged: https://github.com/bioconda/bioconda-recipes/pull/42192

huzuner commented 1 month ago

curl: (28) Failed to connect to eutils.ncbi.nlm.nih.gov port 443 after 20000 ms: Timeout was reached I guess there were some connections issues there. Could you perhaps rerun the tests?

huzuner commented 1 month ago

And for the ModuleNotFoundError: No module named 'distutils' error, I guess spades should be updated as discussed here: https://github.com/ablab/spades/issues/1266

alethomas commented 1 month ago

I already made a PR for the spades update but I guess in order to get this one working I need to merge it

huzuner commented 1 month ago

One of the technology tests is failing with:

Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

This also seems to be present in the master branch. Could that be because of using the same path in Upload logs for both benchmark and technology tests: https://github.com/IKIM-Essen/uncovar/blob/75bd2e7f1cc803f31e8bc36066ab813ee5dd5fb2/.github/workflows/main.yml#L185 and https://github.com/IKIM-Essen/uncovar/blob/75bd2e7f1cc803f31e8bc36066ab813ee5dd5fb2/.github/workflows/main.yml#L377