INN / umbrella-borderzine

Umbrella repository for borderzine.com/
GNU General Public License v2.0
0 stars 1 forks source link

Adds a `homepage middle 1x3 2nd` widget area #71

Closed joshdarby closed 5 years ago

joshdarby commented 5 years ago

Changes

This pull request makes the following changes:

screencapture-borderzine-test-2019-10-03-12_14_07

Why

For #64

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

Steps to test this PR:

  1. Duplicate the widgets in the Homepage Middle 1x3 widget area but with the Voces & Blogs category instead of Diversity and Ideas
  2. Verify it displays exactly like the Diversity and Ideas widget area
joshdarby commented 5 years ago

Note: for #65 we are going to make the News & Art sections look like the Diversity and Voices sections, so I'm going to add work for #65 in this PR instead of a separate one.

joshdarby commented 5 years ago

https://github.com/INN/umbrella-borderzine/pull/71/commits/8e339a077ec0ecf41201228b049b836d824f711a recreates the top 4x4 widget area to be 2 separate 1x3 areas for #65, making the first 4 widget areas after the featured area to be the 1x3 layout.

New testing instructions (since all of the widget areas are renamed so their existing widgets will be gone): For each Homepage Middle n 1x3 widget area:

screencapture-borderzine-test-2019-10-03-14_27_21

benlk commented 5 years ago

Seems to work, and the code checks out.

joshdarby commented 5 years ago

@benlk Is this ok to merge?