INN / umbrella-energynewsnetwork

Umbrella repository for the Energy News Network site, a project of Fresh Energy
https://energynews.us
GNU General Public License v2.0
0 stars 1 forks source link

Fix bug where Link Roundups were appearing on the Region archive page #70

Closed benlk closed 4 years ago

benlk commented 4 years ago

Changes

This pull request makes the following changes:

Why

Fixes #65 by ensuring that a conditional, which checks whether an argument is set in the POSTed params, will not always return false, by correcting the variable name that is checked to the proper name of the array containing the POSTed data

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

Steps to test this PR:

  1. check out master/staging
  2. visit /region/midwest/ and click the "More Posts" button until the page contains an element matching the selector #homepage-bottom article:not(.type-post) or #homepage-bottom article.type-roundup: this is a Roundup, which should not be appearing in the LMP return
  3. check out this branch
  4. Refresh /region/midwest/ and continue clicking until you're satisfied that no markup matching that selector are being returned by the LMP AJAX query.
benlk commented 4 years ago

Deployed in https://github.com/INN/umbrella-energynewsnetwork/pull/69 today.