Open MirandaEcho opened 4 years ago
Status:
The problem with the widget areas is as described in https://github.com/INN/umbrella-energynewsnetwork/issues/77#issuecomment-583161630:
For unknown reasons, creating a sidebar named "Digest Sidebar" in Theme Options > Layout > Sidebar Options, and saving that sidebar in the sidebar picker at Posts > Categories > "Digests" > edit > Archive Sidebar, results in that sidebar not being found by the elaborate fallback queue in sidebar.php, and as a result the sidebar is not output.
The expectation was that we'd be able to use existing Largo functionality to create a named widget area and output it only on this page.
Instead, that named widget area is not output upon the page.
It is not known why this is the case.
Our options are:
1 has an unknown amount of time. 2 makes things weird in a way that might confuse the client, but shouldn't take more than an hour.
I thought we had decided to hardcode it given the difficulty, so let's go ahead with that.
@MirandaEcho I'm guessing that we should add some padding to these textwidgets?
@benlk - yes please. We didn't budget any fancy styling, but some basic cleanup would be good. Lets remove the border and make the button match the other button in the sidebar, at least.
Also, what's up with the description/title for the subscribe widget and all that extra text there?
In that screenshot, I used a Ninja Forms widget. The extra text is what the widget was configured to output.
We should ask them if they're using Ninja Forms for the mailchimp signups now rather than the ENN Mailchimp Subscribe widget we built them.
The default style of the widget is to have padding and border; it looks like Largo removes the padding at certain viewport sizes:
The theme contains a style that removes the borders when the widget has the "Reverse" background class applied, so not removing the border here is more-respecting of the existing styles.
There's CSS being injected via the Customizer that makes the Ninja Forms button wider than the column on some screen sizes:
#nf-field-33 {
padding: 0.75em 2.3em;
margin: 16px 0 0 0;
}
And a lot of other CSS affecting the Ninja Form.
Here's where I ended up at on Desktop:
And on Mobile:
These changes try not to have an adverse effect on the article pages, which have different layouts for that text.
But the fact of the matter is, the Ninja Forms widget has weird markup that makes it hard to guarantee that the input
won't go beyond the container, because an input type="button"
's text content isn't text, but instead its value
attribute. The CSS rules for wrapping text don't apply.
ENN Digest Page Wireframe (1).pdf