IRNAS / irnas-zephyr-template

Template for Zephyr Projects

3 stars 1 forks source link

Update template to NCS v2.7.0 #32

Closed vid553 closed 2 weeks ago

vid553 commented 3 weeks ago

Description

This PR updates the template to work with NCS v2.7.0.

The only major change is a new hardware model (hwm2), so the custom board def was ported. The process was done with help from this commit: https://github.com/zephyrproject-rtos/example-application/pull/58/files#diff-8be52c15d51e72bc3db4b93d1a0a3b7c7cc71cef146678515af659578e1cf53c

Renode sample and sample test were verified and they work with new board definitions on the new NCS. Documentation has been updated with new commands.

Areas of interest for the reviewer

All changed files.

Checklist

[x] My code follows the [style guidelines] as defined by IRNAS.
[x] I have performed a self-review of my code.
[x] My changes generate no new warnings.
[x] I added/updated source code documentation for all newly added or changed functions.
[ ] I updated all customer-facing technical documentation.

After-review steps

Reviewer can merge and delete the branch.

[style guidelines]: https://github.com/IRNAS/irnas-guidelines-docs/blob/main/docs/developer_guidelines.md

vid553 commented 3 weeks ago

#32 👈
#31
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @vid553 and the rest of your teammates on Graphite

vid553 commented 3 weeks ago

Minor thing regarding the custom_nrf52840 to custom_nrf52840dk name change.

The custom_nrf52840 represents the old naming scheme that was used in the Zephyr versions, prior to 3.6.0, basically <board name>_<used soc>_<extra qualifiers>.

So, custom is the name of the board and the nrf52840 is the soc. If we translate that to the newer model, then the board name changes to custom/nrf52840, instead of custom_nrf52840dk.

Please correct this, I think such board name will make adoption of the new hardware model easier and more clear.

I have only ported the board to new model and did not rename it. I have added another commit that renames the board to custom_board (nrf52840 qualifier is not needed in the name as it's added automatically, since this board only has a single SOC possible).

MarkoSagadin commented 3 weeks ago

I have only ported the board to new model and did not rename it.

I see that I made a mistake, you are right, the board was named custom_nrf52840dk, before I assumed that it was named custom_nrf52840 because of the changes in the boards README.md file (which were originally wrong).

Thank you for fixing that :)

I have added another commit that renames the board to custom_board (nrf52840 qualifier is not needed in the name as it's added automatically, since this board only has a single SOC possible).

That is okay, I think that this is a good choice.

I consider this PR as done, just please squash the commits that contain the requested changes into the original two commits.