ITISFoundation / osparc-issues

🐼 issue-only repo for the osparc project
3 stars 5 forks source link

Viewers cannot close studies containing dynamic services successfully #774

Closed elisabettai closed 1 year ago

elisabettai commented 1 year ago

Long Story Short Viewers can't close a study containing e.g. a jupyterlab-math successfully.

Expected Behavior Viewers can view a study and go back to the dashboard. Going back to the dashboard shouldn't trigger any save operation.

Actual behaviour When a viewer closes a study containing e.g. a jupyterlab-math it stays in closing state forever. In the dy-sidecar we have this error: Task simcore_service_dynamic_sidecar.modules.long_running_tasks.task_save_state.5be177ad-0bf8-49eb-b2ba-63e4df32d10e finished with exception: 'Insufficient access rights to write 20361db0-6997-11ed-adc2-02420a0b2082/1834bcea-791f-4346-994c-8876816fe3bc/workspace.zip'

Steps to reproduce

  1. Create a study with a recent jupyter-math (e.g. version 2.0.8)
  2. Share it with a collaborator and assign him the "Viewer" role
  3. The viewer opens the study, optionally do something
  4. The viewer goes back to the dashboard -> the study stays closing forever.

Environment osparc.io

Additional context According to @odeimaiz, this should be better handled at the backend side: e.g. catching this Insufficient access rights error and close it.

GitHK commented 1 year ago

@elisabettai could you please confirm this. I think it is no longer the case! I cannot reproduce it on master any longer. If so please close this case.

elisabettai commented 1 year ago

Hi @GitHK, yep, that's not the case anymore. Closing it.